👋 Welcome back qxing! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@MaxXSoft This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8346831: Remove the extra closing parenthesis in CTW Makefile

Reviewed-by: liach, kbarrett, lmesnik, jwaters

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

• b3e6363: 8343224: print/Dialog/PaperSizeError.java fails with MediaSizeName is not A4: A4
• 60e0730: 8346712: Remove com/sun/net/httpserver/TcpNoDelayNotRequired.java test
• 807f6f7: 8346847: [s390x] minimal build failure

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@liach, @kimbarrett, @lmesnik, @TheShermanTanker) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@MaxXSoft The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Webrevs

• 00: Full (e33d1539)

@liach
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 2 Reviewers).

@liach @kimbarrett @lmesnik Thanks for the review!

It looks like the macOS x64 tier1 gc test timed out, I'm rerunning it. Although this patch has nothing to do with it.

/integrate

@MaxXSoft
Your change (at version e33d153) is now ready to be sponsored by a Committer.

/sponsor

Going to push as commit 7995847.
Since your change was applied there have been 3 commits pushed to the master branch:

• b3e6363: 8343224: print/Dialog/PaperSizeError.java fails with MediaSizeName is not A4: A4
• 60e0730: 8346712: Remove com/sun/net/httpserver/TcpNoDelayNotRequired.java test
• 807f6f7: 8346847: [s390x] minimal build failure

Your commit was automatically rebased without conflicts.

@TheShermanTanker @MaxXSoft Pushed as commit 7995847.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@TheShermanTanker Thanks for the sponsor!

Based on the discussion in #22861, this patch should be backported to 24.

/backport :jdk24

@MaxXSoft the backport was successfully created on the branch backport-MaxXSoft-79958470-jdk24 in my personal fork of openjdk/jdk. To create a pull request with this backport targeting openjdk/jdk:jdk24, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 79958470 from the openjdk/jdk repository.

The commit being backported was authored by Qizheng Xing on 29 Dec 2024 and was reviewed by Chen Liang, Kim Barrett, Leonid Mesnik and Julian Waters.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk:

$ git fetch https://github.com/openjdk-bots/jdk.git backport-MaxXSoft-79958470-jdk24:backport-MaxXSoft-79958470-jdk24
$ git checkout backport-MaxXSoft-79958470-jdk24
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk.git backport-MaxXSoft-79958470-jdk24

⚠️ @MaxXSoft You are not yet a collaborator in my fork openjdk-bots/jdk. An invite will be sent out and you need to accept it before you can proceed.

@TheShermanTanker Can you verify that ctw now builds?